feat: make conventionalcommits default preset - #858
Conversation
…s for default preset
|
i'm excited to move this forward, but there are other pieces to this effort that we will need to coordinate, like the release-notes-generator. also, the conflict with commitlint seems to be ongoing, so i'm hesitant to switch our default if that is going to result in problems for folks using that in addition to semantic-release (which we do recommend using together). if we do move this forward with coordination across our other package(s), we need to make sure that is handled somehow. |
|
I'll look into the part that needs to be coordinated fir sure.
How'd you mean we do not recommend though??? It is true we might have to switch defaults too on |
we do recommend using with commitlint. however, folks that have been using semantic-release and commitlint, and installing locally, have been running into problems with conflicting versions of the underlying conventional-changelog package.
right, once we update core to depend on these new major versions, these changes will be realized there. i'm just not confident that there wont also be some changes needed in core without investigating further. i think this change will be disruptive enough that we will want to release as a prerelease across the impacted packages before promoting |
|
I suggest we ship this change and then release 26-beta of semantic release with conventional commits |
gr2m
left a comment
There was a problem hiding this comment.
release as new breaking release
BREAKING CHANGE: replace angular commit standards with conventional commits. The only change is that append ! after the type or type+scope will now also trigger a breaking change.
This pull request updates the default commit message parsing preset from
angulartoconventionalcommits, aligning the project with the Conventional Commits specification.Changes Made
lib/load-parser-config.jsto useconventional-changelog-conventionalcommitsas the default preset instead ofconventional-changelog-angular. [1] [2]conventional-changelog-angularwithconventional-changelog-conventionalcommitsin runtime dependencies inpackage.json.conventionalcommitsas the default preset instead ofangular, ensuring test coverage matches the new behavior. [1] [2]README.mddocumentation fromangulartoconventionalcommits, clarifying expected behavior for users.Related Issue
Fixes semantic-release/semantic-release#3406
Fixes #231
Fixes #759
Closes semantic-release/semantic-release#1836
Closes semantic-release/semantic-release#1652