feat(db): role-keyed dbFor clients for cleanup and exec workloads

[TheodoreSpeaks]

Summary

• Adds cleanup and exec entries to DB_POOL_PROFILES and a lazy, per-role-cached dbFor('cleanup' | 'exec') factory in @sim/db — sub-process pools selected per call-site, for workloads that live inside an existing process: cleanup jobs run in the trigger.dev worker, inline execution log writes run in the Next.js web server. SIM_DB_ROLE remains restricted to web/trigger/realtime.
• Inert until infra exists: dbFor resolves DATABASE_URL_CLEANUP / DATABASE_URL_EXEC with fallback to the base DATABASE_URL, so today these clients hit the same Postgres with their own local pool. DB_APP_NAME does not leak into them — they always report their profile appName (sim-cleanup / sim-exec). Both are tripwire-instrumented (instrumentPoolClient) with the role as the pool label.
• Cleanup callsites: background/cleanup-logs.ts, cleanup-soft-deletes.ts, and cleanup-tasks.ts run all their queries on dbFor('cleanup'); the lib/cleanup/batch-delete.ts helpers now accept an optional dbClient (default: global db, so other consumers are unchanged). snapshotService.cleanupOrphanedSnapshots (only invoked from cleanup-logs) also moved to the cleanup pool.
• Exec callsites: execution-log persistence in lib/logs/execution/logger.ts (idempotency read, start INSERT, the self-contained completion transaction, getWorkflowExecution), all workflow_execution_logs writes in logging-session.ts (progress-marker fallback UPDATEs, status reads, markExecutionAsFailed), and the workflow-state snapshot upsert in snapshot/service.ts run on dbFor('exec'). Billing/usage-ledger work (advisory-lock reconcile transaction, subscription/org lookups, PII-settings read) deliberately stays on the default client.
• Test infra: databaseMock / dbChainMock in @sim/testing expose dbFor returning the shared mock instance; local @sim/db mocks in the touched suites updated the same way.

Type of Change

• New feature

Testing

• packages/db: tsc --noEmit clean; vitest 24/24 (tx-tripwire + connection-url).
• apps/sim: tsc --noEmit — no new errors (one pre-existing error in providers/meta/index.ts exists on clean origin/staging).
• vitest: cleanup suites, lib/logs/execution/** (191 tests), plus every other suite that locally mocks @sim/db and transitively imports the touched modules (66 tests) — all passing.
• bun run lint:check and bun run check:api-validation:strict pass.

Checklist

• I have signed the CLA

🤖 Generated with Claude Code

https://claude.ai/code/session_01NNy9Fzpfc1FdHAzYyb6Ycy

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs	Ready	Preview, Comment	Jul 11, 2026 2:07am

[cursor]

PR Summary

Medium Risk
Touches hot paths (execution log completion transactions) and retention deletes; behavior is unchanged when sub-pool URLs are unset, but misconfigured DATABASE_URL_* could route traffic to the wrong database once infra wires dedicated pools.

Overview
Introduces per-call-site database pools via dbFor('cleanup' | 'exec') in @sim/db, with new cleanup and exec pool profiles (sim-cleanup / sim-exec app names) and optional DATABASE_URL_CLEANUP / DATABASE_URL_EXEC overrides. SIM_DB_ROLE is limited to web / trigger / realtime; sub-pools are not process roles. Until dedicated URLs exist, sub-pools fall back to the process’s primary URL but keep separate connection budgets.

Cleanup path: background jobs (cleanup-logs, cleanup-soft-deletes, cleanup-tasks), chat-cleanup, large-value prune/mark helpers, and orphaned snapshot deletion run on dbFor('cleanup'). Shared delete helpers in batch-delete gain an optional dbClient (default remains global db).

Exec path: workflow_execution_logs persistence (start, completion transaction, reads, progress markers, failure updates) and execution snapshot upsert/read use dbFor('exec'). Billing and usage-ledger work on the execution logger stays on the default db.

Test mocks expose dbFor → same instance so existing chain seeding still works.

^{Reviewed by Cursor Bugbot for commit 143b382. Bugbot is set up for automated code reviews on this repo. Configure here.}

[TheodoreSpeaks]

@greptile review

[greptile-apps]

Greptile Summary

This PR adds role-specific database clients for cleanup and execution workloads. The main changes are:

• Adds cleanup and exec pool profiles in @sim/db.
• Adds a lazy dbFor('cleanup' | 'exec') client factory.
• Routes cleanup jobs through the cleanup pool.
• Routes execution log and snapshot persistence through the exec pool.
• Updates test database mocks to expose dbFor.

Confidence Score: 5/5

This looks safe to merge.

• No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
packages/db/db.ts	Adds cleanup and exec pool profiles plus the dbFor factory for role-specific clients.
apps/sim/background/cleanup-logs.ts	Moves cleanup log queries and large-value cleanup work onto the cleanup client.
apps/sim/background/cleanup-soft-deletes.ts	Moves soft-delete cleanup reads and deletes onto the cleanup client.
apps/sim/background/cleanup-tasks.ts	Moves task cleanup reads and deletes onto the cleanup client.
apps/sim/lib/cleanup/batch-delete.ts	Adds optional client injection for shared cleanup delete helpers.
apps/sim/lib/cleanup/chat-cleanup.ts	Moves chat file collection reads onto the cleanup client.
apps/sim/lib/execution/payloads/large-value-metadata.ts	Adds optional client injection for large-value tombstone marking and metadata pruning.
apps/sim/lib/logs/execution/logger.ts	Moves execution log persistence reads and writes onto the exec client.
apps/sim/lib/logs/execution/logging-session.ts	Moves execution progress and status updates onto the exec client.
apps/sim/lib/logs/execution/snapshot/service.ts	Uses the exec client for snapshot reads and writes, with cleanup scans on the cleanup client.

_{Reviews (4): Last reviewed commit: "fix(db): dbFor falls back to the process..." | Re-trigger Greptile}

[greptile-apps]

Greptile Summary

This PR adds workload-specific database clients for cleanup and execution logging. The main changes are:

• Adds cleanup and exec pool profiles plus a cached dbFor factory.
• Routes cleanup jobs through the cleanup client.
• Routes execution-log persistence and snapshot writes through the exec client.
• Lets batch-delete helpers accept an explicit database client.
• Updates env validation and database mocks for the new keyed clients.

Confidence Score: 5/5

This looks safe to merge.

• No blocking issues found in the changed code.
• The changed cleanup paths consistently use the cleanup client.
• The changed execution-log paths consistently use the exec client where intended.
• The new database factory is cached per role and keeps process-role validation separate from workload clients.

Important Files Changed

Filename	Overview
packages/db/db.ts	Adds cleanup and exec pool profiles, keeps process roles restricted, and exposes a cached dbFor factory.
apps/sim/lib/cleanup/batch-delete.ts	Adds an optional client parameter to cleanup delete helpers while preserving the existing default client.
apps/sim/background/cleanup-logs.ts	Moves cleanup log queries and delete helpers to the cleanup client.
apps/sim/background/cleanup-soft-deletes.ts	Moves soft-delete cleanup selects and deletes to the cleanup client.
apps/sim/background/cleanup-tasks.ts	Moves task cleanup queries and deletes to the cleanup client.
apps/sim/lib/logs/execution/logger.ts	Moves execution-log persistence to the exec client while keeping billing work on the default client.
apps/sim/lib/logs/execution/logging-session.ts	Moves progress markers, status reads, and failure writes to the exec client.
apps/sim/lib/logs/execution/snapshot/service.ts	Moves snapshot upserts to the exec client and orphan cleanup to the cleanup client.
apps/sim/lib/core/config/env.ts	Adds optional keyed database URLs for cleanup and exec pools.
packages/testing/src/mocks/database.mock.ts	Extends shared database mocks so dbFor returns the same mock instance as db.

_{Reviews (2): Last reviewed commit: "feat(db): role-keyed dbFor clients for c..." | Re-trigger Greptile}

[TheodoreSpeaks]

@greptile review

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit c7ac96b. Configure here.}

[TheodoreSpeaks]

@greptile review