Skip to content

fix: quote argument-hint YAML values so Copilot CLI ≥1.0.65 loads all skills (closes #5626)#5627

Open
thejesh23 wants to merge 1 commit into
simstudioai:mainfrom
thejesh23:fix/quote-argument-hint-yaml
Open

fix: quote argument-hint YAML values so Copilot CLI ≥1.0.65 loads all skills (closes #5626)#5627
thejesh23 wants to merge 1 commit into
simstudioai:mainfrom
thejesh23:fix/quote-argument-hint-yaml

Conversation

@thejesh23

Copy link
Copy Markdown

Closes #5626.

Summary

Purely mechanical single-character transform to 9 file(s): wrap the value after argument-hint: in double quotes so YAML parses it as a string instead of a flow-sequence array. Fixes GitHub Copilot CLI ≥ 1.0.65 silently dropping the skill.

- argument-hint: [foo]
+ argument-hint: "[foo]"

Bare [...] is YAML flow-sequence syntax → the loader receives ["foo"] (a list), fails its str validation, and rejects the SKILL without an error. Claude Code, VS Code Agent Skills, and every other loader document argument-hint as a string; the quoted-string form is what all reference docs show.

Files (9)

  • .claude/commands/cleanup.md
  • .claude/commands/ship.md
  • .claude/commands/you-might-not-need-a-memo.md
  • .claude/commands/you-might-not-need-an-effect.md
  • .claude/commands/you-might-not-need-state.md
  • .claude/commands/react-query-best-practices.md
  • .claude/commands/emcn-design-review.md
  • .claude/commands/you-might-not-need-a-callback.md
  • .claude/commands/you-might-not-need-url-state.md

Verification

  • YAML round-trip via yaml.safe_load on every changed frontmatter reports argument-hint as str
  • Regression sweep: no unquoted-bracket argument-hint: lines remain in these files
  • No vulnerable value contained " or \, so bare double-quote wrapping is safe

Sources

… skills

`argument-hint: [foo]` YAML-parses as a flow sequence (array), not a
string. Downstream slash-command loaders that validate `argument-hint`
as a string — notably GitHub Copilot CLI ≥ 1.0.65 — silently reject
the skill on load, and the command disappears from the CLI menu.

Wrap the value in double quotes so it parses as a string. No behaviour
change on Claude Code.
@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

@thejesh23 is attempting to deploy a commit to the Sim Team on Vercel.

A member of the Team first needs to authorize it.

@cursor

cursor Bot commented Jul 12, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation-only frontmatter quoting in agent command files; no runtime application code changes.

Overview
Wraps argument-hint frontmatter values in double quotes across nine .claude/commands/*.md slash-command skills so YAML treats them as strings instead of flow sequences.

Unquoted values like [scope] [fix=true|false] were parsed as YAML arrays, which caused GitHub Copilot CLI ≥1.0.65 to fail str validation and silently drop those skills; Claude Code and other loaders already expect a string hint.

Reviewed by Cursor Bugbot for commit 65e2714. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes command frontmatter so bracketed argument hints load as strings.

  • Quoted argument-hint values in nine .claude/commands files.
  • Kept the displayed hint text unchanged.
  • Avoided new escaping concerns because the changed values contain no double quotes or backslashes.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
.claude/commands/cleanup.md Quoted the command argument-hint frontmatter value.
.claude/commands/emcn-design-review.md Quoted the command argument-hint frontmatter value.
.claude/commands/react-query-best-practices.md Quoted the command argument-hint frontmatter value.
.claude/commands/ship.md Quoted the command argument-hint frontmatter value.
.claude/commands/you-might-not-need-a-callback.md Quoted the command argument-hint frontmatter value.
.claude/commands/you-might-not-need-a-memo.md Quoted the command argument-hint frontmatter value.
.claude/commands/you-might-not-need-an-effect.md Quoted the command argument-hint frontmatter value.
.claude/commands/you-might-not-need-state.md Quoted the command argument-hint frontmatter value.
.claude/commands/you-might-not-need-url-state.md Quoted the command argument-hint frontmatter value.

Reviews (1): Last reviewed commit: "fix: quote argument-hint YAML values so ..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skills fail to load in GitHub Copilot CLI ≥1.0.65 due to array-shaped argument-hint

1 participant