Skip to content

fix(ux): balance question-card spacing and drop stray SMTP icon dot#5794

Merged
waleedlatif1 merged 1 commit into
stagingfrom
worktree-fix+question-card-spacing
Jul 21, 2026
Merged

fix(ux): balance question-card spacing and drop stray SMTP icon dot#5794
waleedlatif1 merged 1 commit into
stagingfrom
worktree-fix+question-card-spacing

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Balance the spacing around Chat question cards: a visible question card (active or answered recap) now uses a 12px trailing gap (pb-3) instead of the row default (pb-6/pb-4), matching the 12px space-y-3 gap above it so the card breathes equally top and bottom. Excludes dismissed cards, which fall back to the normal message rhythm + actions row.
  • Remove the stray notification dot from the SMTP icon so it matches the rest of the emcn line-icons (the envelope path is now identical to the standard mail icon).

Type of Change

  • Bug fix

Testing

Tested manually.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 21, 2026 2:02am

Request Review

@cursor

cursor Bot commented Jul 21, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Cosmetic spacing and SVG icon tweaks only; no auth, data, or business-logic changes.

Overview
Chat question cards get tighter bottom spacing when the card is still shown (active or answered recap): assistant rows add pb-3 so the gap below the card matches the 12px above it, instead of the layout’s default pb-6 / pb-4. Dismissed questions keep the normal row padding because they show the standard actions row again.

SMTP icon no longer renders the extra filled circle on the envelope, aligning it with the other emcn line mail icons.

Reviewed by Cursor Bugbot for commit 4ad61b7. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adjusts chat-card spacing and simplifies the SMTP icon. The main changes are:

  • Applies a 12px trailing gap to visible question-card rows.
  • Keeps the normal message gap after dismissed question cards.
  • Removes the fixed dot from the SMTP envelope icon.

Confidence Score: 5/5

This looks safe to merge.

  • The conditional class follows the established Tailwind merging pattern.
  • Dismissal state restores the existing row spacing when the card disappears.
  • The icon change preserves its rendering contract and geometry.
  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/home/components/mothership-chat/mothership-chat.tsx Conditionally overrides the assistant row's bottom padding while its terminal question card is visible.
apps/sim/components/icons.tsx Removes a static circle from SmtpIcon without changing its component API, envelope path, dimensions, or viewBox.

Reviews (1): Last reviewed commit: "fix(ux): balance question-card spacing a..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit 644afd2 into staging Jul 21, 2026
20 checks passed
@waleedlatif1
waleedlatif1 deleted the worktree-fix+question-card-spacing branch July 21, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant