Skip to content

improvement(tools): retire direct execution - #7207

Merged
icecrasher321 merged 7 commits into
stagingfrom
codex/remove-direct-execution
Aug 28, 2026
Merged

improvement(tools): retire direct execution#7207
icecrasher321 merged 7 commits into
stagingfrom
codex/remove-direct-execution

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

Summary

  • remove the retired directExecution runtime and type surface
  • migrate all affected tools to registered semantic operations under lib/internal/<family>/
  • preserve trusted background execution authority and add CI and authoring guidance to prevent regressions

Type of Change

  • Improvement

Testing

  • bun run lint
  • bun run check:audits
  • bun run type-check
  • 22 changed test files, 653 tests passed

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 28, 2026 10:09am

Request Review

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile-apps review this PR

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

@cubic-dev-ai review this PR

@icecrasher321 I can't start this review because your workspace has reached its free monthly review limit. cubic has reviewed 360,373 of the 360,000 allowed lines of code this month. Reviews resume on 1 September 2026 (in 4 days). Paid plans include much higher monthly review limits. Upgrade now to resume reviews.

To help optimise your usage, you can tune cubic to get the most out of your usage limits:

Learn more →

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR replaces retired direct tool execution with registered, server-side semantic operations while retaining the existing tool contracts.

  • Adds the shared internal-operation registry, dispatch, input projection, and execution boundary.
  • Migrates affected integrations to family-specific operation implementations.
  • Adds boundary audits, authoring guidance, and focused regression coverage.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
apps/sim/lib/internal/tool-operations/execute.ts Establishes the common registered-operation execution boundary and forwards cancellation into implementations.
apps/sim/lib/internal/tool-operations/registry.server.ts Registers server-only integration-family dispatchers without exposing their implementations through client metadata.
apps/sim/lib/internal/browser-use/operations/run-task.ts Moves BrowserUse execution into a typed operation with provider-response validation, normalized errors, cancellation propagation, and session cleanup.
apps/sim/tools/types.ts Removes the retired direct-execution type surface and defines the registered internal-operation configuration.
scripts/check-tool-registry-boundary.ts Extends repository auditing to enforce the executable-registry and internal-operation boundary.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Caller[Workflow or trusted caller] --> Tool[Tool definition]
  Tool --> Projection[Operation input projection]
  Projection --> Registry[Server operation registry]
  Registry --> Family[Integration-family dispatcher]
  Family --> Operation[Semantic operation]
  Operation --> Provider[External provider or internal capability]
  Provider --> Result[Structured tool response]
Loading

Reviews (7): Last reviewed commit: "fix(tools): update supabase buckets atom..." | Re-trigger Greptile

Comment thread apps/sim/lib/internal/browser-use/operations/run-task.ts
Comment thread apps/sim/lib/internal/browser-use/operations/run-task.ts Outdated
@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 229 files

Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic

Comment thread apps/sim/lib/internal/cloudflare/operations/get-zone-settings.ts
Comment thread apps/sim/lib/internal/bitbucket/operations/get-file.ts Outdated
Comment thread apps/sim/lib/internal/browser-use/operations/run-task.ts Outdated
Comment thread apps/sim/lib/internal/salesforce/operations/update-custom-field.ts Outdated
Comment thread apps/sim/lib/internal/cloudflare/operations/get-zone-settings.ts
Comment thread apps/sim/lib/internal/browser-use/operations/run-task.ts
Comment thread apps/sim/lib/internal/salesforce/operations/update-custom-field.ts Outdated
Comment thread apps/sim/lib/internal/salesforce/operations/update-custom-field.ts Outdated
Comment thread apps/sim/lib/internal/cbinsights/operations/search-firmographics.ts Outdated
Comment thread apps/sim/lib/internal/slack/operations/get-thread-replies.ts
@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 237 files

Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic

Comment thread apps/sim/lib/internal/salesforce/operations/update-custom-field.ts Outdated
Comment thread apps/sim/lib/internal/github/operations.ts Outdated
Comment thread apps/sim/tools/netsuite/utils.ts Outdated
Comment thread apps/sim/lib/internal/supabase/operations/storage-update-bucket.ts Outdated
Comment thread apps/sim/lib/internal/browser-use/operations/run-task.ts Outdated
Comment thread apps/sim/lib/internal/browser-use/operations/run-task.ts
Comment thread apps/sim/lib/internal/browser-use/operations/run-task.ts
Comment thread apps/sim/lib/internal/microsoft-ad/operations/add-user-app-role-assignment.ts Outdated
Comment thread apps/sim/lib/internal/github/operations.ts
@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 238 files

Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/internal/browser-use/operations/run-task.ts Outdated
Comment thread apps/sim/lib/internal/supabase/operations/storage-update-bucket.ts Outdated
@icecrasher321
icecrasher321 force-pushed the codex/remove-direct-execution branch from afe5e33 to 870d7ef Compare August 28, 2026 09:29
@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 238 files

Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/internal/supabase/operations/storage-update-bucket.ts Outdated
Comment thread apps/sim/lib/internal/supabase/operations/storage-update-bucket.ts
@icecrasher321
icecrasher321 force-pushed the codex/remove-direct-execution branch from 870d7ef to ddcbb26 Compare August 28, 2026 09:57
@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 238 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 238 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic

@icecrasher321
icecrasher321 merged commit 9f594c9 into staging Aug 28, 2026
27 checks passed
@icecrasher321
icecrasher321 deleted the codex/remove-direct-execution branch August 28, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant