improvement(ui): consolidate fade-only overflow - #7225
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
@cubic review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Contributor
Greptile SummaryThe PR standardizes single-line, read-only labels on shared fade-only overflow behavior and full-value tooltips.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failures identified. The shared primitives preserve clipping, conditional full-value tooltips, rich-content fallbacks, and existing code-preview truncation, while the updated callers consistently supply the required plain labels.
|
| Filename | Overview |
|---|---|
| packages/emcn/src/components/overflow-text/overflow-text.tsx | Centralizes hard clipping and conditional edge fading while extending keyboard tooltip targeting to menu items. |
| packages/emcn/src/components/dropdown-menu/dropdown-menu.tsx | Introduces a canonical menu-item label and preserves Radix asChild composition while normalizing plain-text children. |
| packages/emcn/src/components/combobox/combobox.tsx | Moves non-editable visual overlays onto the shared overflow primitive while retaining the interactive layer’s tooltip. |
| packages/emcn/src/components/chip-dropdown/chip-dropdown.tsx | Applies shared fade-only rendering to plain trigger and option labels with a hard-clipped fallback for rich content. |
| packages/emcn/src/components/chip-select/chip-select.tsx | Consolidates trigger and menu option overflow handling without changing selection behavior. |
| packages/workflow-renderer/src/lib/overflow-span.tsx | Routes ordinary renderer labels through shared fade-only overflow while preserving truncation for code previews. |
| packages/workflow-renderer/src/workflow-block/sub-block-row-view.tsx | Removes duplicated truncation classes now owned by the renderer’s shared overflow wrapper. |
Reviews (1): Last reviewed commit: "improvement(ui): consolidate fade-only o..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist