Skip to content

Fix broken links to ml-stars primitive JSON files (#670) - #673

Open
godarrenw wants to merge 1 commit into
sintel-dev:masterfrom
godarrenw:gh-670-fix-mlstars-primitive-links
Open

Fix broken links to ml-stars primitive JSON files (#670)#673
godarrenw wants to merge 1 commit into
sintel-dev:masterfrom
godarrenw:gh-670-fix-mlstars-primitive-links

Conversation

@godarrenw

Copy link
Copy Markdown

Resolves #670.

What

Repoints the seven primitive reference pages from MLBazaar/mlstars to sintel-dev/ml-stars.

Why

MLBazaar/mlstars no longer exists, so every one of these json links 404s. The package the project actually depends on is ml-stars (setup.py:26: 'ml-stars>=0.2.1.dev0,<0.4'), which lives at sintel-dev/ml-stars — same master branch, same mlstars/primitives/ layout and same filenames, so only the owner/repo segment changes.

#670 reported this; credit to @karishmavelisetty for finding it.

How I checked

Each of the seven URLs was resolved with curl -L before and after the change:

Primitive JSON old new
sklearn.impute.SimpleImputer.json 404 200
statsmodels.tsa.arima_model.Arima.json 404 200
mlstars.custom.timeseries_preprocessing.rolling_window_sequences.json 404 200
keras.Sequential.LSTMTimeSeriesRegressor.json 404 200
mlstars.custom.timeseries_preprocessing.time_segments_aggregate.json 404 200
mlstars.custom.timeseries_preprocessing.intervals_to_mask.json 404 200
sklearn.preprocessing.MinMaxScaler.json 404 200

I also confirmed no MLBazaar link remains that should have been updated: the only other occurrence is the citation of the MLBazaar paper in primitives.rst:209, which is a paper title rather than a repository reference — its arXiv link and the neighbouring sintel.dev/ml-stars link both return 200, so both were left alone.

The contributing guide asks for unit tests with a PR; this one only changes URLs inside .rst documentation, so there is no code path to cover.

Disclosure: prepared with AI assistance; every URL above was verified manually.

Signed-off-by: Zhu yizhang <95731595+godarrenw@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: broken links to MLBazaar/mlstars primitive JSON files (repo appears removed)

2 participants