Fix broken links to ml-stars primitive JSON files (#670) - #673
Open
godarrenw wants to merge 1 commit into
Open
Conversation
Signed-off-by: Zhu yizhang <95731595+godarrenw@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #670.
What
Repoints the seven primitive reference pages from
MLBazaar/mlstarstosintel-dev/ml-stars.Why
MLBazaar/mlstarsno longer exists, so every one of thesejsonlinks 404s. The package the project actually depends on isml-stars(setup.py:26:'ml-stars>=0.2.1.dev0,<0.4'), which lives atsintel-dev/ml-stars— samemasterbranch, samemlstars/primitives/layout and same filenames, so only the owner/repo segment changes.#670 reported this; credit to @karishmavelisetty for finding it.
How I checked
Each of the seven URLs was resolved with
curl -Lbefore and after the change:sklearn.impute.SimpleImputer.jsonstatsmodels.tsa.arima_model.Arima.jsonmlstars.custom.timeseries_preprocessing.rolling_window_sequences.jsonkeras.Sequential.LSTMTimeSeriesRegressor.jsonmlstars.custom.timeseries_preprocessing.time_segments_aggregate.jsonmlstars.custom.timeseries_preprocessing.intervals_to_mask.jsonsklearn.preprocessing.MinMaxScaler.jsonI also confirmed no
MLBazaarlink remains that should have been updated: the only other occurrence is the citation of the MLBazaar paper inprimitives.rst:209, which is a paper title rather than a repository reference — its arXiv link and the neighbouringsintel.dev/ml-starslink both return 200, so both were left alone.The contributing guide asks for unit tests with a PR; this one only changes URLs inside
.rstdocumentation, so there is no code path to cover.Disclosure: prepared with AI assistance; every URL above was verified manually.