docs(098): fix quickstart fixture path and sabotage recipes - #1000
Merged
Conversation
Related #969 The quickstart pointed at internal/testdata/ctl-server.js (never shipped) with DESC_FILE knobs from the QA harness; the fixture that actually ships is internal/server/testdata/preflight_fixture_server.js with FIXTURE_TOOLS_FILE / FIXTURE_INIT_DELAY_MS / FIXTURE_FAIL_FILE. Recipes rewritten to be copy-paste runnable against it (tools.json seed, env wiring, per-cell sabotage steps). Reported by the #969 author while validating v0.58.0.
Deploying mcpproxy-docs with
|
| Latest commit: |
59416a3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c616a8d7.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://docs-preflight-fixture-path.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 32006192034 --repo smart-mcp-proxy/mcpproxy-go
|
Dumbris
enabled auto-merge (squash)
August 17, 2026 07:51
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approving docs-only fix: quickstart fixture path + runnable sabotage recipes, reported by the #969 author while validating v0.58.0. CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #969
Reported by @neylwalecki while validating v0.58.0:
specs/098-tools-preflight/quickstart.mdpointed atinternal/testdata/ctl-server.js, which never shipped — the real fixture isinternal/server/testdata/preflight_fixture_server.js.Beyond the path swap, the recipes now match the shipped fixture's actual knobs (it serves no default tools):
tools.json(echounannotated for themissing_annotationcell,wipewithdestructiveHint:trueforpolicy_filtered) and wire it viaFIXTURE_TOOLS_FILEin the server envserver_unhealthy:FIXTURE_FAIL_FILE+ kill (sticks across reconnects, no flapping)server_initializing:FIXTURE_INIT_DELAY_MSDocs-only; no code changes.