fix: trivial tests for more accurate coverage - #1213
Draft
SomePersonFromMars wants to merge 2 commits into
Draft
Conversation
Base automatically changed from
refactor/strip-audioeventhandlerregistry-dependency
to
main
August 5, 2026 14:34
Some modules were unlinked in the tests, which made the tests coverage unrealistic
closetcaiman
force-pushed
the
refactor/cpp-tests-improvement
branch
from
August 5, 2026 14:34
6f3e1a6 to
8032b7a
Compare
SomePersonFromMars
marked this pull request as ready for review
August 6, 2026 17:23
SomePersonFromMars
marked this pull request as draft
August 7, 2026 08:36
closetcaiman
reviewed
Aug 7, 2026
| #include <memory> | ||
|
|
||
| namespace audioapi::test { | ||
|
|
Member
There was a problem hiding this comment.
I'd add here (and in other tests) some kind of codetag to signalise that this should/will be changed in the future. Like TODO/FIXME notation or equivalent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
AnalyserNode,RecorderAdapterNode,RotatingFileWriter,ParamControlQueue,HostNode,CircularOverflowableAudioArray,ThreadPool.AudioEventHandlerRegistry,AudioRecorder,AudioFileWriter,AudioRecorderCallback,AudioFilePropertieswere left out).Checklist
Stack created with GitHub Stacks CLI • Give Feedback 💬