feat: add wincode serialization as alternative to bincode - #328
Draft
kskalski wants to merge 1 commit into
Draft
Conversation
Add a `wincode` feature to the interface crate that implements `ConfigKeys` (de)serialization, `get_config_data` and the instruction builders on top of wincode instead of bincode. The encoding is byte-identical to bincode; `wincode` takes precedence when both features are enabled. Bump solana-instruction, solana-pubkey, solana-short-vec and solana-system-interface to versions exposing their `wincode` features, and drop the unused solana-account dependency from the interface crate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
wincodefeature to the interface crate that implementsConfigKeys(de)serialization,get_config_dataand the instruction builders on top of wincode instead of bincode. The encoding is byte-identical to bincode;wincodetakes precedence when both features are enabled.Bump solana-instruction, solana-pubkey, solana-short-vec and solana-system-interface to versions exposing their
wincodefeatures, and drop the unused solana-account dependency from the interface crate.