Skip to content

Fix bound action registration cleanup#568

Open
brenelz wants to merge 1 commit into
solidjs:nextfrom
brenelz:fix-action-registration-cleanup
Open

Fix bound action registration cleanup#568
brenelz wants to merge 1 commit into
solidjs:nextfrom
brenelz:fix-action-registration-cleanup

Conversation

@brenelz

@brenelz brenelz commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve a newer bound action registration when an older owner with the same action URL is disposed
  • add regression coverage for repeated .with() bindings that share a URL
  • add a patch changeset

This fixes forms falling through to native submission at https://action/... after an optimistic update recreates a bound action.

Testing

  • pnpm test
  • pnpm vitest run test/data/action.spec.ts test/data/events.spec.ts
  • pnpm test:types

@changeset-bot

changeset-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9abccb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant