Support RFC 6364 and IS-05 SMPTE 2022-5 FEC SDP (alternative to #505) - #515
Open
garethsb wants to merge 2 commits into
Open
Support RFC 6364 and IS-05 SMPTE 2022-5 FEC SDP (alternative to #505)#515garethsb wants to merge 2 commits into
garethsb wants to merge 2 commits into
Conversation
garethsb
force-pushed
the
fix/is05-fec-alt
branch
2 times, most recently
from
July 29, 2026 11:46
9e15c7d to
e2e845d
Compare
garethsb
marked this pull request as draft
July 29, 2026 12:16
Parse and generate fec-source-flow, fec-repair-flow, and repair-window. Use digits_converter for DIGIT fields, and an optional trailing object_converter field so m= format lists may be omitted.
Map FEC transport parameters to RFC 6364 SDP attributes.
Require resolved fec_mode ("1D"/"2D") when creating SDP.
Parse concrete fec_mode from repair-flow count; leave unused
fec2D_destination_port as "auto". Resolve receiver staged
fec_mode auto from /constraints as the highest available
number of dimensions.
Co-authored-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
garethsb
force-pushed
the
fix/is05-fec-alt
branch
from
July 29, 2026 14:53
e2e845d to
00db78d
Compare
Contributor
Author
|
@lo-simon, this #515 is fundamentally @thangldw's nice work from #505 rebased onto #512 and #514, with:
This PR still needs a big review; there's a fair bit of complexity in the FEC SDP handling and conversion to/from IS-05 |
garethsb
marked this pull request as ready for review
July 29, 2026 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternative to #505, based on @thangldw's
fix/is05-fecplus @garethsb's thangldw/nmos-cpp#1 trailing-field simplification. Rebased ontomasterafter #514.FEC/UDP,UDP/FEC,FEC-FR,fec-source-flow,fec-repair-flow,repair-windowobject_converterfield som=format lists may be omittednmos/sdp*fec_mode(1D/2D) when creating SDP; parse concrete mode from repair-flow countfec_mode: autofrom/constraints(highest enum value, or2Dwhen unconstrained)Commits (this PR vs
master)Testing
Linux Release: all
testSdp*/*Fec*(681 assertions in 37 cases).Related to #38.