reimplement: SHC_3BB0A8C1_0x00449F10 100%#160
Merged
Conversation
TheRedDaemon
added
the
declaration/type change
Contributor
|
Let's go with |
Contributor
|
See f9f579d |
TheRedDaemon
force-pushed
the
reimpl/SHC_3BB0A8C1_0x00449F10
branch
from
July 18, 2026 21:00
e628d74 to
158179e
Compare
TheRedDaemon
removed
the
declaration/type change
TheRedDaemon
marked this pull request as ready for review
July 18, 2026 21:02
gynt
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now I only changed the parameter names, but maybe the naming could also be changed?
This function here is just another version of
playSFXAtLocationwithout the volume part. It basically just pans the sound, but does not make it quieter or louder.