chore: stop tracking Policyfile.lock.json - #199
Merged
Conversation
The lock pins the cookbook to an exact version, but release-please only
bumps metadata.rb. When the two disagree, ChefSpec's policyfile install
aborts the whole RSpec suite before any example runs:
CookbookOmnifetch::CookbookValidationFailure: The cookbook downloaded
for Cookbook 'ruby_build' = 2.5.12 {:path=>"."} did not satisfy the constraint.
The lock cannot simply be version-bumped either, since it also carries
content-derived identifier and dotted_decimal_identifier fields.
chefignore already excludes it from the published artifact, and 171 of 179
sous-chefs repos do not track it.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Lance Albertson <lance@osuosl.org>
sous-chefs/.github@9.0.0 declares slack_bot_token and slack_channel_id as required secrets. Without them the reusable workflow is invalid, so every push to main ends in startup_failure and release-please never runs. Included here so merging this PR actually results in a release. See sous-chefs/freebsd#90 for the same fix after a merge produced no release. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Lance Albertson <lance@osuosl.org>
Contributor
Author
|
Added a second commit passing the required slack secrets to the release workflow.
Without this, merging this PR would land the change and silently produce no release. That is exactly what happened in sous-chefs/freebsd#88, which needed sous-chefs/freebsd#90 as a follow-up. Both secrets already exist as sous-chefs org secrets with |
ramereth
force-pushed
the
fix/untrack-policyfile-lock
branch
from
August 16, 2026 21:07
b9d4be0 to
5bb5516
Compare
Slowest examplesTop 10 slowest examples (0.6 seconds, 99.99% of total time)
|
ramereth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Policyfile.lock.jsonis tracked and pinsruby_buildto an exact version (2.5.12), while release-please only bumpsmetadata.rb(currently2.5.12). Whenever the two disagree, ChefSpec's policyfile install aborts the entire RSpec suite before a single example runs:Fix
Untrack the lock. It is a generated artifact —
chefignorealready excludes it from the published cookbook, and 171 of 179 sous-chefs repos do not track it.Bumping the version inside the lock is not a viable alternative: it also carries
identifieranddotted_decimal_identifierfields derived from cookbook content.Same fix as sous-chefs/logrotate#226.
This change is