Use npm install in verify-no-snapshot-versions test workflow#3
Merged
Merged
Conversation
The workflow ran npm ci, which requires a committed package-lock.json. Lock files are gitignored across this repo, so npm ci fails with EUSAGE (no package-lock.json). Switch to npm install to match every other action test workflow (extract-bom-versions, update-project-versions, etc.). Signed-off-by: Ryan Baxter <rbaxter85@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-verify-no-snapshot-versions.ymlrannpm ci, which requires a committedpackage-lock.json. Lock files are gitignored across this repo (.gitignorehas an unscopedpackage-lock.jsonentry), sonpm cifails with:This switches both
npm cicalls tonpm install, matching every other action test workflow in the repo (test-extract-bom-versions,test-update-project-versions, etc.).Failing run: https://github.com/spring-cloud/spring-cloud-github-actions/actions/runs/29770906179