Fix expected step name in spring-release-train-project-ready validation#4
Merged
Merged
Conversation
The action's step was renamed from 'Commit and push release version changes' to 'Commit and push changes', but the action.yml validation in the test workflow still expected the old name, so it failed with 'Missing expected step'. Update the expected step name to match. Signed-off-by: Ryan Baxter <rbaxter85@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Validate action.ymljob intest-spring-release-train-project-ready.ymlfailed with:The action's step was renamed from Commit and push release version changes → Commit and push changes (
spring-release-train-project-ready/action.yml:128— it now also deletes CI/PR workflows, so it commits more than just version changes), but the validator'sexpectedStepslist still checked the old name.This updates the expected step name to match. Verified against the current action.yml — all other expected steps (
Checkout project release branch,Update project versions,Verify no snapshot versions,Trigger release-train-ready workflow) still match.Failing run: https://github.com/spring-cloud/spring-cloud-github-actions/actions/runs/29770906119