Collect nested generic arguments when resolving type signatures - #3531
Open
arimu1 wants to merge 1 commit into
Open
Collect nested generic arguments when resolving type signatures#3531arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
`TypeUtils.resolveTypesInSignature` skipped nested arguments of a raw type that was already seen, so `V` in `Map<K, Map<K, V>>` was missing from the AOT type set. Closes spring-projects#3530 Signed-off-by: arimu1 <19286898+arimu1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultAotRepositoryContext.discoverTypes()collects reachable domain types viaTypeCollector.inspect(…), which delegates toTypeUtils.resolveTypesInSignature. Cycle detection used the rawClass, so a nested parameterization of a type already seen (for exampleVinMap<K, Map<K, V>>) was skipped. One-levelMap<K, V>was collected as expected.This change visits generic arguments using the
ResolvableTypesignature instead of the raw class, so nested component types are included in the AOT type set used for accessor generation.TypeCollectorUnitTests.detectsTypesNestedMoreThanOneGenericLevelfails on currentmain(EmptyType2missing) and passes with this change.Closes #3530