v7.7 - #2475
Open
kinkie wants to merge 2 commits into
Open
Conversation
rousskov
reviewed
Aug 17, 2026
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
Contributor
Author
|
@rousskov thanks for the correction. is it okay now? |
rousskov
reviewed
Aug 18, 2026
| Changes in squid-7.7 (17 Aug 2026): | ||
|
|
||
| - Protect several base64 encoding buffers | ||
| - Fix support for squidconf directive parameter files |
Contributor
There was a problem hiding this comment.
This is very minor:
Suggested change
| - Fix support for squidconf directive parameter files | |
| - Fix support for squid.conf directive parameter files |
However, the above is rather misleading because nothing has changed as far as "parameter files" themselves are concerned. FWIW, I would recommend being more specific about this important fix and reuse the corresponding commit title:
Suggested change
| - Fix support for squidconf directive parameter files | |
| - Honor directive parameters after a quoted filename reference |
Alternatively, if you insist on using less precise1 "parameter files" wording here:
Suggested change
| - Fix support for squidconf directive parameter files | |
| - Honor squid.conf directive parameters listed after parameter files |
Footnotes
-
Squid supports two kinds of directive parameter files, but only "quoted filename" kind is relevant here. ↩
yadij
approved these changes
Aug 19, 2026
Contributor
|
approved. modulo what you decide to do with @rousskov request |
squid-anubis
added
M-waiting-staging-checks
Contributor
|
@kinkie, just FYI: Our FreeBSD build tests have failed for this PR with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.