Define MSG_DONTWAIT as MSG_NONBLOCK if needed and possible - #2477
Open
reshmavk wants to merge 5 commits into
Open
Define MSG_DONTWAIT as MSG_NONBLOCK if needed and possible#2477reshmavk wants to merge 5 commits into
reshmavk wants to merge 5 commits into
Conversation
squid-anubis
added
the
M-failed-description
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
squid-anubis
removed
the
M-failed-description
... by deleting a stale TODO (addressed by 2025 commit 5be401d).
rousskov
changed the title
rousskov
reviewed
Aug 19, 2026
Contributor
There was a problem hiding this comment.
Thank you for this fix! I made it a bit more general and updated its location to where current master/v8 code places these kind of hacks. I did not test my changes. Please check!
I adjusted PR description, primarily to avoid retelling what the diff already clearly says. Please adjust further as needed.
I have two followup questions, but this PR is on the right track.
rousskov
added
the
S-waiting-for-author
rousskov
approved these changes
Aug 20, 2026
rousskov
left a comment
rousskov
left a comment
Contributor
There was a problem hiding this comment.
It is usually best to introduce Squid-specific constants than to define/fix "standard" ones, but Squid already violates that rule of thumb for MSG_NOSIGNAL, so I think we can go with the proposed solution, especially since it fixes AIX build.
rousskov
added
M-cleared-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIX does not define
MSG_DONTWAIT. The functional equivalent of thisflag on AIX is
MSG_NONBLOCK.This change fixes the above mentioned compilation error on AIX.