docs(source): resolve the third gate pass's findings - #208
Merged
Conversation
…y + poison-loop and panic semantics P1 (doc-consistency): doc.go no longer promises 'exactly within a session' redelivery for offset-riding backends; it now scopes in-session redelivery to each adapter's documented constraints (naming Kafka's concurrent-commit caveat explicitly), matching handler.go and the kafka README. P2s: Nak-after-Ack outcome specified (does not unmark; persisted position stays past the record; an in-session re-seek may still redeliver once); foreign-settle detection boundary spelled out (sibling-subscription Kafka records apply as if delivered); missing-DLQ-topic steady state documented on the README setup notes (ErrNoDLQTopic per settle, record unmarked, partition stalls until configured); Begin documents that a panic inside fn is not recovered and leaves the transaction open until End, session close, or a rebalance fence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint 4.8 — gate rerun-5 contract findings
Gate rerun 5 adversary: 15 HELD / 1 BROKEN(doc-level) / 3 UNDOCUMENTED, findings F1(P1)/F2-F5(P2) — all documentation consistency; zero code defects.
Full three-panel gate reruns on this merge as final clearance.