ci(release): validate modules standalone (GOWORK=off) and lint on the newest Go leg only - #212
Merged
Merged
Conversation
… newest Go leg only
The first source-module tags exposed two latent release-workflow issues:
- source/kafka is deliberately excluded from go.work, but the validate job
ran with the root workspace present, so 'go test ./...' inside the module
failed on every leg ('directory prefix . does not contain modules listed
in go.work'). Set GOWORK=off for the whole gate: released modules must
build standalone anyway; replace directives carry intra-repo deps.
- golangci-lint is compiled by the active toolchain; on the go1.25 legs it
refused a module whose toolchain directive targets a newer language
version ('can't load config: the Go language version (go1.25) used to
build golangci-lint is lower than the targeted Go version (1.26.4)').
Lint now runs on the 1.26.6 leg only; test -race still covers 1.25.x.
Also adds [1.0.1] release-engineering entries to both source changelogs:
the v1.0.0 tags stay immutable; v1.0.1 republishes the identical source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint 5 fix-forward — release workflow repairs for the v1 tags
Cutting
source/v1.0.0+source/kafka/v1.0.0surfaced two latentrelease.ymlissues (first source-module release ever; both failures are environmental, zero code defects):pattern ./...: directory prefix . does not contain modules listed in go.workon every legrelease.ymlnever setsGOWORK=off;source/kafkais deliberately outside the workspaceGOWORK: "off"on the validate job (released modules must build standalone; replace directives cover intra-repo deps)can't load config: the Go language version (go1.25) used to build golangci-lint is lower than the targeted Go version (1.26.4)on all 1.25.14 legs1.26.6leg (test -racestill covers 1.25.x)Also:
[1.0.1]release-engineering changelog entries for both modules. Per policy the pushed v1.0.0 tags stay immutable; v1.0.1 patch tags will be cut from this merge to publish successfully.