fix: set base_log_folder to display task logs in the UI - #834
Open
sweb wants to merge 7 commits into
Open
Conversation
20 tasks
Member
|
@sbernauer I'm not the best person to review this as I co-authored it |
adwk67
removed their request for review
August 7, 2026 13:35
razvan
self-requested a review
August 10, 2026 08:03
razvan
previously approved these changes
Aug 10, 2026
razvan
left a comment
Member
There was a problem hiding this comment.
lgtm with two small suggestions
sweb
force-pushed
the
chore/missing-logs-repro
branch
from
August 11, 2026 10:15
12d7154 to
0a981a0
Compare
sweb
commented
Aug 11, 2026
sweb
left a comment
Member
Author
There was a problem hiding this comment.
addressed comments and resolved conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Airflow UI should be able to show task logs which are requested from the worker pod. This requires setting
BASE_LOG_FOLDERto the correct place, which differs from our log mount - this PR fixes that.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker