fix: Make serviceAccount.name and serviceAccount.create work - #418
Open
lfrancke wants to merge 2 commits into
Open
fix: Make serviceAccount.name and serviceAccount.create work#418lfrancke wants to merge 2 commits into
lfrancke wants to merge 2 commits into
Conversation
Same fix as hive-operator#742, applied to the two CSI workloads. serviceAccount.name had no effect: the ServiceAccount and both workloads hardcoded <fullname>-serviceaccount, so the value was silently ignored. They now resolve the name through operator.serviceAccountName. With serviceAccount.create=false the helper fell back to "default", giving pods running as the namespace default ServiceAccount without the operator's ClusterRole. It now requires serviceAccount.name, so the chart fails to render instead of installing something that cannot work. Rendered output is unchanged for the default values. _helpers.tpl and serviceaccount.yaml are generated from operator-templating and are ahead of the template until the matching change lands there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as stackabletech/hive-operator#742 please read there for details.
Fixing this here before I move the rest to operator templating because when we fix the
_helpers.tplandserviceaccount.yamlin templating they will be merged here and suddenly potentially make the whole create and name stuff actually work but those non-templated two files will still refer to the old SA which now doesn't exist and the pod won't start.In other words: Currently it's ignored (broken). If we don't fix it here first pods might not start. So we fix it here first, then do templating.
secret-operatorhas the same two workloads and needs the same fix.