Skip to content

feat(dremio): stop returning oauth client secret on get/list dremio(s)#1576

Merged
Fyusel merged 6 commits into
stackitcloud:mainfrom
r-savu:feat/STACKITDER-894-stop-returning-client-secret-on-get-dremio
Jul 14, 2026
Merged

feat(dremio): stop returning oauth client secret on get/list dremio(s)#1576
Fyusel merged 6 commits into
stackitcloud:mainfrom
r-savu:feat/STACKITDER-894-stop-returning-client-secret-on-get-dremio

Conversation

@r-savu

@r-savu r-savu commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description

@r-savu r-savu requested a review from a team as a code owner July 9, 2026 12:39
@Fyusel Fyusel self-assigned this Jul 10, 2026
Comment thread stackit/internal/services/dremio/instance/resource.go Outdated
@r-savu r-savu force-pushed the feat/STACKITDER-894-stop-returning-client-secret-on-get-dremio branch from c128fdd to 697bc47 Compare July 10, 2026 16:04

@Fyusel Fyusel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • linter issues :-)

Comment thread stackit/internal/services/dremio/instance/resource.go Outdated
Comment thread stackit/internal/services/dremio/instance/resource.go
Comment thread stackit/internal/services/dremio/instance/datasource.go
@Fyusel

Fyusel commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Please run: make generate-docs

Robert Savu added 6 commits July 14, 2026 13:09
Treviously the get dremio and list dremio endpoints were returning the
full IDP config, including the client secret.

The client secert should be known by the IDP and the instance itself and
not be returned by "routine" get/list requests.
…ent_secret

- Fixes the runtime validation failure where  apply  fails with
inconsistent values for sensitive attribute  under the authentication
block.
@r-savu r-savu force-pushed the feat/STACKITDER-894-stop-returning-client-secret-on-get-dremio branch from e02b8b8 to 86599c0 Compare July 14, 2026 11:09
@Fyusel Fyusel enabled auto-merge (squash) July 14, 2026 11:28
@Fyusel Fyusel disabled auto-merge July 14, 2026 11:28
@Fyusel Fyusel enabled auto-merge (squash) July 14, 2026 11:29
@Fyusel Fyusel merged commit bdaca71 into stackitcloud:main Jul 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants