Fix early-readiness version check for ACS 4.9 - #270
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change raises the minimum supported operator version for additional printer columns from 4.9.0 to 4.10.0 and updates the related documentation. ChangesAdditional Printer Columns Version Support
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized version-check change with no actionable merge-blocking risk remaining after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #269 by tightening the version gate used when --early-readiness=false, preventing roxie from waiting on an Available condition that does not exist on older StackRox/ACS operator-managed CRs (notably in mixed-version deployments).
Changes:
- Update the minimum supported operator version for the relevant readiness/feature gate from
>= 4.9.0to>= 4.10.0. - Align the inline documentation with the updated constraint value.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fix for issue #269
It appears that the condition >=4.9 was wrong:
So it looks like the feature was first shipped in ACS 4.10.0, not 4.9.0