connection_pool: recover instances after a cluster restart#343
Open
Mockird31 wants to merge 1 commit into
Open
connection_pool: recover instances after a cluster restart#343Mockird31 wants to merge 1 commit into
Mockird31 wants to merge 1 commit into
Conversation
Mockird31
marked this pull request as draft
July 20, 2026 13:44
Mockird31
force-pushed
the
mockird31/gh-328-recover-pool-restart
branch
from
July 20, 2026 16:22
a1ce92b to
5cb4cf4
Compare
Mockird31
marked this pull request as ready for review
July 20, 2026 17:03
Contributor
|
Should be |
Mockird31
force-pushed
the
mockird31/gh-328-recover-pool-restart
branch
from
July 21, 2026 19:53
5cb4cf4 to
3a4f1e4
Compare
Treat any instance error as an unhealthy state instead of an unhandled exception. An instance which has not finished its bootstrap yet replies with an error to `box.info`, and the `Response` constructor raises it as a plain DatabaseError. `_get_new_state()` caught only a NetworkError, so the error escaped the background refresh loop and killed its thread. Close the socket if a handshake fails: `is_closed()` only checks the socket, so such a connection was reported as open and was never authenticated again. Closes #328
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat any instance error as an unhealthy state instead of an unhandled exception. An instance which has not finished its bootstrap yet replies with an error to
box.info, and theResponseconstructor raises it as a plain DatabaseError._get_new_state()caught only a NetworkError, so the error escaped the background refresh loop and killed its thread.Close the socket if a handshake fails:
is_closed()only checks the socket, so such a connection was reported as open and was never authenticated again.Closes #328