Remove nono credential isolation - #39
Closed
bborn wants to merge 1 commit into
Closed
Conversation
nono never reliably worked (Landlock/proxy-credential issues) and no active GMs depend on it. Remove the entire integration: - Delete templates: nono-exec, nono-profile, nono-stub - setup.sh: drop NONO_* config, proxy-flag generation, the setup_nono function, and both call sites - gm-doctor: remove the Credential Isolation check + summary row - Strip references from launch.md, README, config.example.env, project-claude-md.tmpl, exe-dev/gm-launcher.tmpl, slack README Hermetic QA harness: 29 passed, 0 failed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
nono credential isolation never reliably worked (Landlock kernel quirks + the proxy-credential blocker) and no active GMs depend on it. The three GMs that had
NONO_ENABLED=true(mna-os, kinfolk, offerlab-devs) have been decommissioned, so this removes the dead integration entirely.Changes
nono-exec.sh.tmpl,nono-profile.json.tmpl,nono-stub.sh.tmplNONO_*config exports, proxy-flag generation, thesetup_nono()function (~150 lines), and both call sites (server + exe.dev)launch.md,README.md,config.example.env,project-claude-md.tmpl({{#NONO}}block),exe-dev/gm-launcher.tmpl, and the Slack module READMEdocs/plans/*left untouched (historical design record).Verification
bash -n setup.shcleannono/NONO_references outsidedocs/plans/qa/run-qa.sh): 29 passed, 0 failed, including a realsetup.sh serverprovision that exits 0 — executor setup works without the nono wrappers🤖 Generated with Claude Code