feat: allows get to resolve services as singletons - #2256
Open
aidan-casey wants to merge 1 commit into
Open
Conversation
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit a6a9cfe |
innocenzi
reviewed
Aug 19, 2026
innocenzi
left a comment
Member
There was a problem hiding this comment.
Not a blocker, but I am not a fan of this:
getgets a hidden behaviormakedoes whatgetused to dogetandmakearen't clear names, they have minor differences in their behavior, so consumers have to read docs or code dive
I feel like we're unlocking a niche use case while making the container more confusing. I don't have an alternative to suggest, however.
Member
|
I've reviewed this PR internally on Discord, but here is the review for clarity:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the conversations with @Crell in the Tempest discord, this PR allows services to be shared by default and adds a secondary
makemethod that always retrieves a new instance of the class.Note the definition of the
makemethod that PHP-DI has:https://php-di.org/doc/container.html#make