Skip to content

[SDK Sentinel] Stabilize Nexus abandon cancellation test #3043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdk-sentinel-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SDK Sentinel] Stabilize Nexus abandon cancellation test #3043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions temporal-sdk/src/test/java/io/temporal/workflow/nexus/CancelWorkflowAsyncOperationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,6 @@ public void cancelAsyncOperationAbandon() {
// Cancel before command is sent
runCancelBeforeSentTest(NexusOperationCancellationType.ABANDON);

// For ABANDON, the handler workflow may start even in the cancel-before-sent case,
// which can set opStarted and handlerFinished. Clear them before the after-start test.
opStarted.clearSignal();
handlerFinished.clearSignal();

// Cancel after operation is started
WorkflowStub stub =
testWorkflowRule.newUntypedWorkflowStubTimeoutOptions("TestNexusOperationCancellationType");
Expand Down Expand Up @@ -240,13 +235,16 @@ public void execute(
TestNexusService serviceStub =
Workflow.newNexusServiceStub(TestNexusService.class, serviceOptions);

long finishDelay = cancelImmediately ? 0L : 2000L;
NexusOperationHandle<Void> handle =
Workflow.startNexusOperation(serviceStub::operation, 2000L);
Workflow.startNexusOperation(serviceStub::operation, finishDelay);
if (cancelImmediately) {
CancellationScope.current().cancel();
}
handle.getExecution().get();
opStarted.signal();
if (!cancelImmediately) {
opStarted.signal();
}

// Wait to receive request to cancel, then block until operation result promise is ready.
try {
Expand Down