Skip to content

Make eager activity reservation limit configurable#1674

Open
Sushisource wants to merge 4 commits into
mainfrom
eager-activity-slot-limit
Open

Make eager activity reservation limit configurable#1674
Sushisource wants to merge 4 commits into
mainfrom
eager-activity-slot-limit

Conversation

@Sushisource

@Sushisource Sushisource commented Jul 24, 2026

Copy link
Copy Markdown
Member

What changed

  • Add max_eager_activity_reservations_per_workflow_task to Worker and its configuration types.
  • Forward the configured value through the Python bridge into Core.
  • Preserve the existing default of three.
  • Reject non-positive values with guidance to use disable_eager_activity_execution=True to disable eager execution.
  • Update the Core submodule to the merged configurable-limit implementation.

Why

Core already caps the number of slots it attempts to reserve for eager activities while completing a workflow task. This exposes that existing cap to Python users without introducing a separate execution-lifetime limit.

Validation

  • poe format
  • poe build-develop
  • poe bridge-lint
  • Focused Pyright check for the changed worker and replay paths
  • uv run pytest tests/worker/test_worker.py::test_worker_max_eager_activity_reservations_per_workflow_task_config tests/worker/test_worker.py::test_worker_rejects_non_positive_max_eager_activity_reservations -q

The broad lint/test collection additionally requires optional contrib dependencies that are not installed in this workspace. No breaking changes; the default remains three.

@Sushisource Sushisource changed the title Expose eager activity concurrency limit Make eager activity reservation limit configurable Jul 24, 2026
@Sushisource
Sushisource force-pushed the eager-activity-slot-limit branch from 5cfdf0c to 260c33e Compare July 24, 2026 23:23
@Sushisource
Sushisource marked this pull request as ready for review July 24, 2026 23:24
@Sushisource
Sushisource requested a review from a team as a code owner July 24, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant