feat(extstore): Add support for Nexus task handling#1676
Open
jmaeagle99 wants to merge 1 commit into
Open
Conversation
jmaeagle99
commented
Jul 25, 2026
|
|
||
| def _decode_reference(self, payload: Payload) -> ExternalStorageReference | None: | ||
| """Decode an external storage reference from a payload.""" | ||
| if len(payload.external_payloads) == 0: |
Contributor
Author
There was a problem hiding this comment.
The Nexus task transport drops the external_payloads field. Regardless, it shouldn't be checking for this field anyway and should only rely on the metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
external_payloadscondition from reference check.Why?
Round out the support for external storage for all task handlers.
Checklist
How was this tested: Integration tests
Any docs updates needed? No