Fix JSON conversion for dict[None, T] keys#1677
Open
hsusul wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize the literal
Nonekey argument produced by built-indict[None, T]type hints so JSON object keys serialized as"null"arerestored to Python
None.Fixes #1237.
Root cause
Built-in generics and
typing.Dictexpose this annotation differently:dict[None, str]yields literalNoneas its key argumenttyping.Dict[None, str]yieldsNoneTypeThe mapping converter treated literal
Noneas an absent key type, so it leftthe JSON key as
"null".The normalization is intentionally mapping-specific. It does not alter unrelated
annotations such as
Literal[None].Changes
NonetoNoneTypewhile selecting a mapping key converter{None: "1"}Validation
test_json_type_hintstests/test_converter.py: 28 passedpoe lintgit diff --check