-
Notifications
You must be signed in to change notification settings - Fork 11
MLDSA signature validation support #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| /** | ||
| * Copyright (c) 2026, WSO2 LLC. (https://www.wso2.com). | ||
| * | ||
| * WSO2 LLC. licenses this file to you under the Apache License, | ||
| * Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import {exportJWK, generateKeyPair, SignJWT} from 'jose'; | ||
| import {DefaultCrypto} from '../DefaultCrypto'; | ||
| import TokenConstants from '../constants/TokenConstants'; | ||
| import {JWKInterface} from '../models/crypto'; | ||
|
|
||
| describe('DefaultCrypto.verifyJwt with ML-DSA (AKP JWKs)', (): void => { | ||
| it.each(['ML-DSA-44', 'ML-DSA-65', 'ML-DSA-87'] as const)( | ||
| 'verifies an id_token signed with %s against its AKP JWK', | ||
| async (alg): Promise<void> => { | ||
| const {publicKey, privateKey} = await generateKeyPair(alg, {extractable: true}); | ||
| const jwk = (await exportJWK(publicKey)) as unknown as JWKInterface; | ||
| jwk.alg = alg; | ||
| jwk.kid = `test-${alg}`; | ||
| jwk.use = 'sig'; | ||
|
|
||
| const idToken: string = await new SignJWT({}) | ||
| .setProtectedHeader({alg, kid: jwk.kid}) | ||
| .setIssuedAt() | ||
| .setIssuer('https://issuer.example') | ||
| .setAudience('client-id') | ||
| .setSubject('user-id') | ||
| .setExpirationTime('1h') | ||
| .sign(privateKey); | ||
|
|
||
| const crypto = new DefaultCrypto(); | ||
| const result: boolean = await crypto.verifyJwt( | ||
| idToken, | ||
| jwk, | ||
| TokenConstants.SignatureValidation.SUPPORTED_ALGORITHMS as unknown as string[], | ||
| 'client-id', | ||
| 'https://issuer.example', | ||
| 'user-id', | ||
| ); | ||
|
|
||
| expect(result).toBe(true); | ||
| }, | ||
| ); | ||
|
|
||
| it('rejects an ML-DSA id_token with a tampered signature', async (): Promise<void> => { | ||
| const alg = 'ML-DSA-65'; | ||
| const {publicKey, privateKey} = await generateKeyPair(alg, {extractable: true}); | ||
| const jwk = (await exportJWK(publicKey)) as unknown as JWKInterface; | ||
| jwk.alg = alg; | ||
| jwk.kid = 'test-tampered'; | ||
| jwk.use = 'sig'; | ||
|
|
||
| const idToken: string = await new SignJWT({}) | ||
| .setProtectedHeader({alg, kid: jwk.kid}) | ||
| .setIssuedAt() | ||
| .setIssuer('https://issuer.example') | ||
| .setAudience('client-id') | ||
| .setSubject('user-id') | ||
| .setExpirationTime('1h') | ||
| .sign(privateKey); | ||
|
|
||
| const parts: string[] = idToken.split('.'); | ||
| const tamperedSignature: string = parts[2].slice(0, -4) + (parts[2].endsWith('AAAA') ? 'BBBB' : 'AAAA'); | ||
| const tamperedToken = `${parts[0]}.${parts[1]}.${tamperedSignature}`; | ||
|
|
||
| const crypto = new DefaultCrypto(); | ||
| await expect( | ||
| crypto.verifyJwt( | ||
| tamperedToken, | ||
| jwk, | ||
| TokenConstants.SignatureValidation.SUPPORTED_ALGORITHMS as unknown as string[], | ||
| 'client-id', | ||
| 'https://issuer.example', | ||
| 'user-id', | ||
| ), | ||
| ).rejects.toThrow(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change intentional? why have we marked
eandnas optional attributes?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the JWK format of MLDSA algorithm is different and does not have these parameters