Split TinyAgents into focused workspace crates - #131
Merged
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedToo many files! This PR contains 1039 files, which is 939 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1039)
You can disable this status message by setting the Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86c8e3eb55
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,151 +1,28 @@ | |||
| [package] | |||
| name = "tinyagents" | |||
| [workspace] | |||
There was a problem hiding this comment.
After this root manifest becomes virtual, the inspected .github/workflows/release.yml still sets CRATE_NAME: tinyagents and aborts at lines 60–63 when cargo metadata contains no package by that name, so every release dispatch now fails before versioning. Even if bypassed, its version substitution searches for [package] rather than [workspace.package], and its package/publish commands do not select a focused crate (cargo package --help documents -p as selecting the package(s) to assemble). Update the workflow to version and publish the new members in dependency order.
AGENTS.md reference: AGENTS.md:L5-L11
Useful? React with 👍 / 👎.
# Conflicts: # Cargo.toml
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 048a8aeac7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+7
to
+9
| "crates/tinyagents-registry", | ||
| "crates/tinyagents-session", | ||
| ] |
There was a problem hiding this comment.
With this explicit default-members list, bare Cargo commands operate only on the five listed packages (cargo test --help describes --workspace as “Test all packages in the workspace”). Because ci.yml and the PR template still invoke bare cargo test, cargo build, and cargo clippy, the new tinyagents-integration-tests package is omitted from those normal checks; only the later all-feature coverage command includes it, leaving its default-feature configuration and examples untested and unlinted. Add this package to default-members or update those commands to select the workspace explicitly.
AGENTS.md reference: AGENTS.md:L29-L33
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking changes
There is no tinyagents facade crate. Consumers must depend on and import the individual tinyagents-* crates directly.
Validation