Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/asyncio/graph.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def _build_graph_for_future(
coro = coro.cr_await
elif hasattr(coro, 'ag_await'):
# A native async generator or duck-type compatible iterator
st.append(FrameCallGraphEntry(coro.cr_frame))
st.append(FrameCallGraphEntry(coro.ag_frame))
coro = coro.ag_await
else:
break
Expand Down
26 changes: 26 additions & 0 deletions Lib/test/test_asyncio/test_graph.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import asyncio
import io
import sys
import unittest
from unittest import mock

Expand Down Expand Up @@ -147,6 +148,31 @@ async def main():
'async generator CallStackTestBase.test_stack_async_gen.<locals>.gen()',
stack_for_gen_nested_call[1])

def test_ag_frame_used_for_async_generator(self):
# Regression test for gh-148736: the ag_await branch of
# _build_graph_for_future must read ag_frame, not cr_frame.
from asyncio.graph import _build_graph_for_future

sentinel_frame = sys._getframe()

class FakeAsyncGen:
ag_await = None
ag_frame = sentinel_frame

class FakeCoro:
cr_frame = sentinel_frame
cr_await = FakeAsyncGen()

loop = asyncio.new_event_loop()
try:
fut = loop.create_future()
fut.get_coro = lambda: FakeCoro()
result = _build_graph_for_future(fut)
finally:
loop.close()

self.assertEqual(len(result.call_stack), 2)

async def test_stack_gather(self):

stack_for_deep = None
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_curses.py
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,7 @@ def test_read_from_window(self):
with self.subTest(ch=ch):
stdscr.addstr(2, 0, ch)
self.assertEqual(stdscr.instr(2, 0, 1), b)
self.assertEqual(stdscr.inch(2, 0) & curses.A_CHARTEXT, b[0])
self.assertEqual(stdscr.inch(2, 0), b[0])

def test_coordinate_errors(self):
# Addressing a cell outside the window raises curses.error.
Expand Down
17 changes: 17 additions & 0 deletions Lib/test/test_socket.py
Original file line number Diff line number Diff line change
Expand Up @@ -1787,6 +1787,23 @@ def testGetaddrinfo(self):
except socket.gaierror:
pass

@unittest.skipUnless(hasattr(socket, 'AI_NUMERICSERV'),
'needs socket.AI_NUMERICSERV')
@support.thread_unsafe('setlocale is not thread-safe')
@support.run_with_locales('LC_ALL',
'uk_UA.KOI8-U', 'uk_UA', 'ja_JP.eucJP', 'ja_JP.SJIS', 'ja_JP',
'ko_KR.eucKR', 'zh_CN.GB18030', 'el_GR.ISO8859-7',
'de_DE.ISO8859-1', 'ja_JP.UTF-8',
'')
def test_getaddrinfo_localized_error(self):
# gh-93251: the localized gai_strerror() message could fail to be
# decoded as UTF-8, so UnicodeDecodeError was raised
# instead of gaierror.
with self.assertRaises(socket.gaierror) as cm:
socket.getaddrinfo("localhost", "http",
flags=socket.AI_NUMERICSERV)
str(cm.exception)

@unittest.skipIf(_testcapi is None, "requires _testcapi")
def test_getaddrinfo_int_port_overflow(self):
# gh-74895: Test that getaddrinfo does not raise OverflowError on port.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix a latent :exc:`AttributeError` in :mod:`asyncio` call-graph capture when
walking an async generator's ``ag_await`` chain: the walker referenced
``cr_frame`` instead of ``ag_frame``.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fix :exc:`UnicodeDecodeError` in :mod:`socket` functions
(such as :func:`~socket.getaddrinfo` and :func:`~socket.gethostbyaddr`)
when the localized error message of the C library is not UTF-8:
decode it from the locale encoding.
66 changes: 34 additions & 32 deletions Modules/_cursesmodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -776,30 +776,6 @@ curses_getcchar(const cchar_t *wcval, wchar_t *wstr, attr_t *attrs, int *pair)
return rtn;
}

/* winch() returns the low 8 bits of the character's code point with no locale
conversion, unlike instr(), so recover the locale byte from the wide cell
when the character maps to exactly one byte, keeping the attribute and color
bits in RTN. A character with no single-byte form is left to winch(). */
static chtype
curses_cell_locale_byte(chtype rtn, const cchar_t *cell)
{
wchar_t wstr[CCHARW_MAX + 1];
attr_t attrs;
int pair;
if (curses_getcchar(cell, wstr, &attrs, &pair) == ERR
|| wstr[0] == L'\0' || wstr[1] != L'\0')
{
return rtn;
}
/* wctob() mirrors ncurses' own _nc_to_char(): the single-byte form, or EOF
when the character has none in this locale. */
int byte = wctob(wstr[0]);
if (byte != EOF) {
rtn = (rtn & ~(chtype)A_CHARTEXT) | (unsigned char)byte;
}
return rtn;
}

/* Hash one cell by value (text, attributes, pair) -- consistent with the
equality comparison, not the raw cchar_t whose padding and unused text tail
it ignores. Zero the key first so those bytes are deterministic, then
Expand Down Expand Up @@ -3650,7 +3626,40 @@ _curses_window_inch_impl(PyCursesWindowObject *self, int group_right_1,
{
chtype rtn;
const char *funcname;

#ifdef HAVE_NCURSESW
/* ncursesw's winch() returns the character's whole code point instead of
its locale byte, overflowing the chtype's 8-bit character field into the
color and attribute bits; read the wide cell and rebuild it instead. */
cchar_t cell = {0};
int rc;
if (!group_right_1) {
rc = win_wch(self->win, &cell);
funcname = "win_wch";
}
else {
rc = mvwin_wch(self->win, y, x, &cell);
funcname = "mvwin_wch";
}
if (rc == ERR) {
curses_window_set_error(self, funcname, "inch");
return NULL;
}
wchar_t wstr[CCHARW_MAX + 1];
attr_t attrs;
int pair;
if (curses_getcchar(&cell, wstr, &attrs, &pair) == ERR) {
curses_window_set_error(self, "getcchar", "inch");
return NULL;
}
int byte = 0;
if (wstr[0] != L'\0' && wstr[1] == L'\0') {
byte = wctob(wstr[0]);
if (byte == EOF) {
byte = 0;
}
}
rtn = (chtype)byte | (attrs & ~(attr_t)A_COLOR) | COLOR_PAIR(pair);
#else
if (!group_right_1) {
rtn = winch(self->win);
funcname = "winch";
Expand All @@ -3663,13 +3672,6 @@ _curses_window_inch_impl(PyCursesWindowObject *self, int group_right_1,
curses_window_set_error(self, funcname, "inch");
return NULL;
}
#ifdef HAVE_NCURSESW
curses_cell_t cell = {0};
if ((group_right_1 ? mvwin_wch(self->win, y, x, &cell)
: win_wch(self->win, &cell)) != ERR)
{
rtn = curses_cell_locale_byte(rtn, &cell);
}
#endif
return PyLong_FromUnsignedLong(rtn);
}
Expand Down
14 changes: 12 additions & 2 deletions Modules/socketmodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -745,14 +745,24 @@ set_error(void)
}


#if defined(HAVE_HSTRERROR) || defined(HAVE_GAI_STRERROR)
/* Decode a locale-encoded error message from the C library.
It can be localized and use a non-UTF-8 encoding. */
static PyObject *
decode_error_message(const char *str)
{
return PyUnicode_DecodeLocale(str, "surrogateescape");
}
#endif

#if defined(HAVE_GETHOSTBYNAME_R) || defined (HAVE_GETHOSTBYNAME) || defined (HAVE_GETHOSTBYADDR)
static PyObject *
set_herror(socket_state *state, int h_error)
{
PyObject *v;

#ifdef HAVE_HSTRERROR
v = Py_BuildValue("(is)", h_error, hstrerror(h_error));
v = Py_BuildValue("(iN)", h_error, decode_error_message(hstrerror(h_error)));
#else
v = Py_BuildValue("(is)", h_error, "host not found");
#endif
Expand All @@ -779,7 +789,7 @@ set_gaierror(socket_state *state, int error)
#endif

#ifdef HAVE_GAI_STRERROR
v = Py_BuildValue("(is)", error, gai_strerror(error));
v = Py_BuildValue("(iN)", error, decode_error_message(gai_strerror(error)));
#else
v = Py_BuildValue("(is)", error, "getaddrinfo failed");
#endif
Expand Down
Loading