fix(llamaindex): add safety for "None" attributes, and add key fallback - #4430
fix(llamaindex): add safety for "None" attributes, and add key fallback#4430christabella wants to merge 1 commit into
Conversation
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe LLamaIndex span utility now records the request model from ChangesLLamaIndex instrumentation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change safely handles missing attributes and adds a model-name fallback for LlamaIndex telemetry; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
span.set_attribute(...)calls with the existing_set_span_attributehelper that guards againstNonemodel_nameon LLM model dictsThis prevents OTEL collectors e.g. Datadog from emitting warnings when llamaIndex emits an LLM chat event and model_dict keys "model" and "temperature" are absent.
Summary by CodeRabbit