fix(anthropic): skip NotGiven/Omit sentinel in set_span_attribute - #4432
fix(anthropic): skip NotGiven/Omit sentinel in set_span_attribute#4432nskun wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Anthropic instrumentation now skips ChangesAnthropic sentinel filtering
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized change skips unset Anthropic sentinel values from span attributes and adds regression coverage; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
feat(instrumentation): ...orfix(instrumentation): ....Summary
Skip Anthropic SDK
OmitandNotGivensentinel values inset_span_attribute.This prevents unset optional parameters such as
temperatureandtop_pfrom being passed to OpenTelemetry as invalid span attribute types.Testing
Added regression coverage for both
anthropic.NOT_GIVENandanthropic.Omit().Fixes #4431
Summary by CodeRabbit