fix: align TRON runtime and compiler semantics - #146
Merged
CodeNinjaEvan merged 7 commits intoJul 28, 2026
Merged
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
yanghang8612
marked this pull request as ready for review
July 28, 2026 07:36
CodeNinjaEvan
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validatemultisignasviewbecause it reads current account permission stateDetails
The PR intentionally preserves the existing 168-bit TRON address validation, does not add EOF-specific opcode restrictions, and leaves Standard JSON viaIR behavior unchanged. EOF is already disabled at the CLI, Standard JSON, and
CompilerStackentry points.For the multisignature precompiles:
ValidateMultiSignreads the account, permission, signer weights, and threshold, so the compiler declaration must beviewrather thanpure.BatchValidateSignonly performs signature recovery and address comparison, so it remainspure.allowTvmSolidity059. When the proposal is unavailable, the address follows the empty-code call path and can succeed with zero-length returndata. Legacy codegen reads the pre-zeroed output word as zero, while the previous via-IR decoder reverted on fewer than 32 return bytes. The via-IR path now preserves the established legacy result without changing normal java-tron precompile success or failure handling.Pair.of(false, EMPTY_BYTE_ARRAY). Both compiler backends check the call success flag before decoding or applying short-return compatibility, so these failures still propagate as empty-data reverts.References:
Validation
cmake --build build --target soltest solc -j2StandardCompiler/tron_builtin_via_ir_codegen_guards— passedsyntaxTests/tron/validatemultisign_mutability— passedsyntaxTests/tron/precompiles_before_byzantium— passedsmtCheckerTests/tron/state_mutation_havocs_balance— passedgit diff --check origin/release_0.8.30...HEAD— passed