fix: clarify TRON builtin parameter names - #147
Merged
CodeNinjaEvan merged 1 commit intoJul 28, 2026
Merged
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
yanghang8612
force-pushed
the
fix/release-0.8.30-abi-api-compatibility
branch
from
July 28, 2026 08:12
c5bd564 to
65b4dfd
Compare
yanghang8612
marked this pull request as ready for review
July 28, 2026 08:15
CodeNinjaEvan
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validatemultisign,voteCount, and related vote-query builtinsRoot cause
Several global builtins registered address parameters as
address.validatemultisigntherefore could not be called with named arguments becauseaddressis a Solidity keyword, whilevoteCountregistered both inputs under the same name. Its permission parameter was also exposed as the misspelledpermissonid.The corrected names are:
validatemultisign:account,permissionId,content,signaturesisSrCandidate:srCandidatevoteCount:voter,srCandidatetotalVoteCount:voterreceivedVoteCount:srCandidateusedVoteCount:voterCompatibility
The removed
trcTokenABI canonicalization is not part of this PR. ExistingtrcTokenABI names and selectors remain unchanged.Position-based builtin calls are unchanged. The old named forms affected here were not usable:
addresscannot be parsed as a named-argument identifier, and the duplicateaddresskeys forvoteCountcannot be expressed.Validation
cmake --build build --target soltest -j2syntaxTests/tron/builtin_named_arguments— passedgit diff --check origin/release_0.8.30...HEAD— passed