fix: harden compiler inputs and avoid root LSP scans - #148
Merged
CodeNinjaEvan merged 2 commits intoJul 28, 2026
Merged
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
yanghang8612
force-pushed
the
fix/release-0.8.30-input-path-hardening
branch
from
July 28, 2026 09:19
ec7bc91 to
8072fcf
Compare
yanghang8612
marked this pull request as ready for review
July 28, 2026 10:03
CodeNinjaEvan
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LSP scope
The LSP continues to allow absolute imports, include paths, and symlinks outside the workspace as upstream does. Only eager project discovery at a filesystem root is disabled; in that case the server analyzes directly opened and imported files instead.
Compatibility
This does not change contract ABI, bytecode, or runtime behavior. Normal workspace scanning and import resolution are unchanged. A client that deliberately uses the filesystem root as its project root no longer receives eager diagnostics for every Solidity file on the machine.
Tests
The repository-wide style check still reports the pre-existing trailing whitespace at .github/workflows/build.yml:322.