fix: Fix tag validation regex in deploy.yml - #954
Merged
Conversation
sbansla
approved these changes
Aug 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release workflow’s tag validation logic in .github/workflows/deploy.yml, intended to ensure pushed tags match the package version before publishing to PyPI.
Changes:
- Modified the tag regex validation and error message to require
X.Y.Ztags (instead ofvX.Y.Z). - Adjusted how the version string is derived from the tag before comparing against
setup.py --version.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+84
to
+88
| if [[ ! "$TAG" =~ ^[0-9]+\.[0-9]+\.[0-9]+ ]]; then | ||
| echo "::error::Release tag must be in the form 1.2.3 (got '$TAG')" | ||
| exit 1 | ||
| fi | ||
| VERSION="${TAG#v}" | ||
| VERSION="${TAG#}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
A short description of what this PR does.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.