Reword commit message to stop tracking job failing on main - #4547
Merged
Conversation
* Increase array dimensions for impurity radiation data structures from 200 to 600 to accommodate larger datasets. Updated relevant initialisation parameters in `impurity_radiation_variables.py` and `impurity_radiation.py`. * Add plotting script for total impurity radiation loss function and update documentation - Introduced `impurity_loss_functions.py` to plot Line and Bremsstrahlung loss function profiles. - Updated the electron density in plasma radiation documentation from 10^19 10^20. - Increased the source data points from 200 to 600 and adjusted the fitted temperature range. * Update expected values in unit tests for impurity radiation calculations * Enhance impurity loss function plotting with varied line styles for better visualization * Refactor impurity radiation data structures to use a constant for loss function points and update related calculations * Update documentation/source/physics-models/plasma_radiation.md Co-authored-by: clmould <86794332+clmould@users.noreply.github.com> * Fix impurity path error catching * use N_IMPURITIY_LOSS_FUNCTION_POINTS directly instead of `table_length` alias * Remove redundant assignment to impurity path --------- Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
je-cook
approved these changes
Aug 21, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4547 +/- ##
=======================================
Coverage 49.45% 49.46%
=======================================
Files 150 150
Lines 29914 29912 -2
=======================================
+ Hits 14795 14797 +2
+ Misses 15119 15115 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the {} from the commit message as this was causing the tracking job to fail on main:
Failure on tracking job:
Old commit message:
Description
Checklist
I confirm that I have completed the following checks: