[don't merge] New C++ api#8651
Conversation
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
154 µs | 191.2 µs | -19.44% |
| ❌ | Simulation | encode_varbin[(1000, 4)] |
139 µs | 157.7 µs | -11.81% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
271.6 µs | 306.7 µs | -11.46% |
| ❌ | Simulation | encode_varbin[(1000, 8)] |
139.9 µs | 157.6 µs | -11.27% |
| ❌ | Simulation | encode_varbin[(1000, 2)] |
138.5 µs | 154.7 µs | -10.46% |
| ⚡ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
26.5 µs | 16.2 µs | +63.99% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
205.7 µs | 169.5 µs | +21.36% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
205.8 µs | 169.8 µs | +21.2% |
| ⚡ | Simulation | chunked_varbinview_opt_into_canonical[(1000, 10)] |
219.5 µs | 183.3 µs | +19.76% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
258.5 µs | 223.6 µs | +15.61% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
244.4 ns | 215.3 ns | +13.55% |
| ⚡ | Simulation | compare_int_constant |
298.7 µs | 268.7 µs | +11.18% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
304.7 ns | 275.6 ns | +10.58% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing myrrc/cxx2 (0da0ff4) with develop (452e0f8)1
Footnotes
05babc3 to
5795c45
Compare
a044015 to
a5c7567
Compare
66bfb31 to
de2512a
Compare
| } | ||
|
|
||
| void StructArrayBuilder::Deleter::operator()( | ||
| vx_struct_column_builder* ptr) const noexcept { |
There was a problem hiding this comment.
What's our rule of thumb for sprinkling noexcept?
| } | ||
| session_ = std::move(other.session_); | ||
| stream_ = other.stream_; | ||
| other.stream_ = ArrowArrayStream{}; |
There was a problem hiding this comment.
Also here we do why change other? other.stream_ = ArrowArrayStream{};
f8fdfa0 to
63f5efa
Compare
Depends: #8735