Assortment of VortexSource improvements and fixes#8718
Merged
Conversation
github-actions
Bot
removed
the
action/benchmark-sql
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (3)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 0.894x ✅ How to read Verdict and Engines
datafusion / vortex-file-compressed (0.894x ✅, 7↑ 0↓)
No file size changes detected. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.987x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.989x ➖, 0↑ 0↓)
datafusion / parquet (0.979x ➖, 1↑ 1↓)
datafusion / arrow (0.965x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (0.981x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.985x ➖, 0↑ 0↓)
duckdb / parquet (0.987x ➖, 2↑ 1↓)
duckdb / duckdb (0.988x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.946x ➖, 2↑ 0↓)
datafusion / vortex-compact (0.973x ➖, 1↑ 0↓)
datafusion / parquet (0.973x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.966x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.977x ➖, 1↑ 0↓)
duckdb / parquet (0.999x ➖, 0↑ 1↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.992x ➖, 0↑ 1↓)
datafusion / vortex-compact (0.988x ➖, 0↑ 0↓)
datafusion / parquet (0.979x ➖, 2↑ 1↓)
duckdb / vortex-file-compressed (0.980x ➖, 1↑ 0↓)
duckdb / vortex-compact (0.990x ➖, 1↑ 2↓)
duckdb / parquet (0.989x ➖, 0↑ 1↓)
duckdb / duckdb (1.000x ➖, 1↑ 2↓)
No file size changes detected. |
Contributor
Benchmarks: Clickbench Sorted on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.118x ❌, 0↑ 5↓)
datafusion / parquet (1.063x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.041x ➖, 1↑ 3↓)
duckdb / parquet (0.995x ➖, 0↑ 1↓)
duckdb / duckdb (1.102x ❌, 0↑ 6↓)
File Size Changes (201 files changed, -0.1% overall, 89↑ 112↓)
Totals:
|
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.938x ➖, 1↑ 0↓)
datafusion / vortex-compact (0.938x ➖, 1↑ 0↓)
datafusion / parquet (0.968x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.980x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.978x ➖, 0↑ 0↓)
duckdb / parquet (0.977x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (1.116x ❌, 0↑ 7↓)
duckdb / vortex-compact (1.027x ➖, 0↑ 0↓)
duckdb / parquet (1.094x ➖, 0↑ 3↓)
No file size changes detected. |
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.974x ➖, 1↑ 1↓)
datafusion / parquet (0.968x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (1.006x ➖, 0↑ 4↓)
duckdb / parquet (0.992x ➖, 0↑ 0↓)
duckdb / duckdb (0.983x ➖, 0↑ 0↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.902x ➖, 11↑ 0↓)
datafusion / vortex-compact (0.920x ➖, 2↑ 0↓)
datafusion / parquet (0.920x ➖, 4↑ 0↓)
datafusion / arrow (0.850x ✅, 19↑ 0↓)
duckdb / vortex-file-compressed (0.914x ➖, 7↑ 0↓)
duckdb / vortex-compact (0.951x ➖, 0↑ 0↓)
duckdb / parquet (0.948x ➖, 0↑ 0↓)
duckdb / duckdb (0.944x ➖, 1↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.928x ➖, 2↑ 0↓)
datafusion / vortex-compact (0.811x ➖, 5↑ 0↓)
datafusion / parquet (1.003x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.966x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.960x ➖, 0↑ 0↓)
duckdb / parquet (0.943x ➖, 0↑ 0↓)
|
AdamGS
changed the title
VortexSource improvements and fixes
AdamGS
marked this pull request as ready for review
July 15, 2026 11:00
github-actions
Bot
removed
the
action/benchmark-sql
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
added
the
action/benchmark-sql-full
github-actions
Bot
removed
the
action/benchmark-sql-full
Contributor
Benchmarks: Vortex queriesVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.031x ➖, 0↑ 0↓)
datafusion / parquet (0.943x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.006x ➖, 0↑ 0↓)
duckdb / parquet (1.004x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: Appian on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.942x ➖, 0↑ 0↓)
datafusion / parquet (0.930x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (0.972x ➖, 0↑ 0↓)
duckdb / parquet (0.969x ➖, 0↑ 0↓)
duckdb / duckdb (0.942x ➖, 0↑ 0↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
| static SESSION: LazyLock<VortexSession> = LazyLock::new(VortexSession::default); | ||
|
|
||
| #[derive(Debug, Eq, Hash, PartialEq)] | ||
| struct SnapshotErrorExpr; |
Contributor
There was a problem hiding this comment.
add a doc str explaining why you added this
joseph-isaacs
added
the
action/benchmark
github-actions
Bot
removed
the
action/benchmark
joseph-isaacs
approved these changes
Jul 17, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
enabled auto-merge (squash)
July 17, 2026 11:01
Contributor
Benchmarks: Random AccessVortex (geomean): 1.070x ➖ How to read Verdict and Engines
unknown / unknown (1.046x ➖, 0↑ 6↓)
|
Contributor
Benchmarks: CompressionVortex (geomean): 1.002x ➖ How to read Verdict and Engines
unknown / unknown (0.985x ➖, 1↑ 1↓)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
General improvements of the
FileSource-based Apache DataFusion integration.What changes are included in this PR?
ParquetSourceprovides.batch_sizefrom the source, by default DataFusion splits the data coming out ofDataScanExecnodes.What APIs are changed? Are there any user-facing changes?
More metrics will be reported in DF, and batch size needs to be done through the
DataSourceExecandFileScanConfiglevel.