Lazily untranspose DeltaArray validity and depend on fastlanes bit transpose code#8725
Lazily untranspose DeltaArray validity and depend on fastlanes bit transpose code#8725robert3005 wants to merge 5 commits into
Conversation
Merging this PR will not alter performance
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
26bff75 to
0fd420f
Compare
| struct TransposedBoolMetadata { | ||
| #[prost(uint32, tag = "1")] | ||
| offset: u32, | ||
| } |
There was a problem hiding this comment.
The transport is width dependent no?
There was a problem hiding this comment.
I don't understand what you mean
There was a problem hiding this comment.
There is a lot of shared logic with out blocked arrays?
0fd420f to
774f405
Compare
…anspose code Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
774f405 to
d830e48
Compare
Delta array unnecessarily untraposes whole validity whenever it's queried. This
pr avoids this by laziliy wrapping it in a TransposedBool array that does
untranspose when necessary.
While we're at it we remove the bit transpose logic that has been moved to
fastlanes repo