ci(macos): fail fast on invalid notary credentials - #802
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe macOS release-candidate workflow now separates signing certificate validation from notarization credential validation. The new notarization check validates Apple ID, app-specific password, and team ID secrets through ChangesmacOS release credential validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Protected candidate run 31274913581 signed both x64 and arm64 apps with the configured Developer ID certificate, but Apple notarization then failed on both architectures with HTTP 401 invalid credentials.
This PR adds an explicit
notarytool historyauthentication preflight after compilation and certificate validation, but before electron-builder packaging. Apple ID and app-specific password are now scoped to that dedicated step and the package step rather than the certificate parser. Successful history output is discarded, the check has a five-minute timeout, and the existing always-run certificate cleanup remains unchanged.Apple documents
notarytoolauthentication with Apple ID, app-specific password, and Team ID in its custom notarization workflow guidance.Safety and scope
release.ymlis unchanged.--publish never, fail-closed verdict, and three-day artifact retention are unchanged.Testing
git diff --checkpassed.Type of change
Summary by CodeRabbit