Add roundEven(), isNaN(), isInfinite() to Operators - #936
Merged
Conversation
Collaborator
|
shubhamg13 marked as non substantive for IPR from ash-nazg. |
Contributor
Author
|
cc: @xiaochengh |
shubhamg13
changed the title
huningxin
requested changes
Aug 12, 2026
huningxin
left a comment
huningxin
left a comment
Contributor
There was a problem hiding this comment.
The method names isNan() and isFinite() in the commit title should align with the method names in the code: isNaN() and isInfinite().
shubhamg13
changed the title
Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
Contributor
Author
Done as suggested. Please take a look. |
Contributor
Author
|
Please help me to merge this PR |
Contributor
fdwr
approved these changes
Aug 13, 2026
fdwr
left a comment
fdwr
left a comment
Collaborator
There was a problem hiding this comment.
馃憤 Thanks for filling the gaps.
github-actions Bot
added a commit
that referenced
this pull request
Aug 13, 2026
SHA: 36224cf Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of some operators to List.
Reference: #859
Non-Substantive as no new implementations
Preview | Diff