Export CFLAGS/LDFLAGS before ./config so OpenSSL rpath is actually baked in#444
Merged
ColtonWilley merged 1 commit intoJul 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the OpenSSL build in install_openssl() so the intended RPATH is actually captured during OpenSSL’s configure phase, preventing openssl-install/bin/openssl from depending on LD_LIBRARY_PATH to locate its sibling libssl/libcrypto.
Changes:
- Move
CFLAGS/CXXFLAGS/LDFLAGSexport so it occurs before./config, allowing OpenSSL’s Configure step to bake the flags into the generated Makefile. - Add an explanatory comment documenting why the ordering matters.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aidangarske
force-pushed
the
fix-openssl-rpath-baking
branch
from
July 13, 2026 20:33
60ceba6 to
6766914
Compare
ColtonWilley
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export
LDFLAGSbefore./configinstead of after, so OpenSSL captures the-Wl,-rpathflags at configure time. Without this the rpath was dropped and thebuilt
opensslhad none, leaving it dependent onLD_LIBRARY_PATHto findlibssl.so.3(intermittentcannot open shared object filein CI). Now thebinary self-locates its libs. Makes the intent of
b6ca8e1actually work.preventative for: https://jenkins-supervisor.wolfssl.com/#/open-issues/524