Add upload UI and wire the uploader into the grid#25622
Draft
crazytonyli wants to merge 6 commits into
Draft
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
from
0e6ecbf to
d4572b8
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-ui
branch
from
1e1fa49 to
90df03b
Compare
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33049 | |
| Version | PR #25622 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 8682318 | |
| Installation URL | 3ppj316f6jtlg |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33049 | |
| Version | PR #25622 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 8682318 | |
| Installation URL | 077lrbdk46l10 |
crazytonyli
force-pushed
the
task/media-v2-upload-ui
branch
from
90df03b to
362fcbe
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
2 times, most recently
from
8f96db5 to
adab6df
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-ui
branch
from
362fcbe to
14694c9
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
from
adab6df to
d4a7b1b
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-ui
branch
from
14694c9 to
5db0706
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
from
d4a7b1b to
e91673a
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-ui
branch
2 times, most recently
from
80dac4b to
3206ce1
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
from
e91673a to
db8160b
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-ui
branch
from
3206ce1 to
9e91167
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
from
db8160b to
fb748dd
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-ui
branch
from
9e91167 to
019a63c
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
from
fb748dd to
675d2da
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-ui
branch
from
019a63c to
8384343
Compare
Toolbar Add menu, sticky in-flight banner, and dedicated Uploads screen with per-item and bulk retry/cancel, plus the Photos/camera picker representables. Wires MediaUploader into the view model and adds the external-picker extension point (option + delegate) the app target plugs into.
Expose the materialized temp file URL on PendingUpload and FailedUpload, carry it through UploadRowItem, and render it with QLThumbnailGenerator in place of the kind icon. The icon remains until materialization completes, for failed rows without a retryable payload, and for kinds QuickLook cannot preview.
Materialized uploads now stage in persistent storage that survives app suspension, so a crash or force-quit can leave orphaned files behind. Clear them once at launch, alongside the existing V1 media-cache sweep.
The registry snapshotted MediaSettings and blog options once at first vend, so settings changed later (like Remove Location) never reached the cached uploader. Rebuilding the policy on every uploader(for:) call and pushing it through updatePolicy keeps new enqueues aligned with current settings without dropping in-flight state.
fileImporter never calls onCompletion when the user cancels, so routing it through the picker sheet with a constant-true binding left a blank sheet stuck on screen after Cancel. A dedicated isImportingFile state attached directly to the view lets SwiftUI reset the presentation on cancel natively.
MaterializedUpload derives displayName from the temp file URL.
crazytonyli
force-pushed
the
task/media-v2-upload-engine
branch
from
675d2da to
6bb0246
Compare
crazytonyli
force-pushed
the
task/media-v2-upload-ui
branch
from
8384343 to
8682318
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR will be merged after #25621.