ReadPartitionSession: skipping an empty read batch instead of dropping the rest of the response - #694
Open
Myllyenko wants to merge 1 commit into
Open
Conversation
addBatches returned as soon as it saw a batch with no messages, so every batch after it in the same ReadResponse was silently discarded: the messages never reached the user and the read futures of those batches never completed, which also stopped ReadSession.onReadResponse from requesting more data. Skip the offending batch and keep processing the rest of the response.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #694 +/- ##
============================================
+ Coverage 71.91% 71.94% +0.03%
- Complexity 3474 3475 +1
============================================
Files 390 390
Lines 16220 16220
Branches 1698 1698
============================================
+ Hits 11664 11669 +5
+ Misses 3904 3900 -4
+ Partials 652 651 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addBatchesreturned as soon as it saw a batch with no messages, so every batch after it in the sameReadResponsewas silently discarded: the messages never reached the user and the read futures of those batches never completed, which also stoppedReadSession.onReadResponsefrom requesting more data.